Skip to content

Conversation

yyzxw
Copy link
Contributor

@yyzxw yyzxw commented Aug 21, 2025

close: #19

@yyzxw yyzxw force-pushed the chore/update-filename branch from c0da950 to fb7ea9c Compare August 21, 2025 03:51
Copy link
Collaborator

@elevran elevran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments might still need the use of filter/scorer in them.

@elevran
Copy link
Collaborator

elevran commented Aug 25, 2025

@yyzxw thanks for the contribution!
I've left some minor comments (mostly relating to use of the filter/scorer in comments).
Please resolve conflicts/rebase and be sure to sign the commits

@yyzxw yyzxw force-pushed the chore/update-filename branch from fb7ea9c to 6827d97 Compare August 26, 2025 09:42
Copy link
Collaborator

@elevran elevran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@elevran
Copy link
Collaborator

elevran commented Aug 26, 2025

thank you for following up on the review comments.
The code is still missing a verified signature.
See #311 (comment) for example and instructions.

@yyzxw yyzxw force-pushed the chore/update-filename branch from 6827d97 to b937ab2 Compare August 27, 2025 06:32
@yyzxw yyzxw force-pushed the chore/update-filename branch from b937ab2 to d4b8c91 Compare August 27, 2025 06:34
@yyzxw
Copy link
Contributor Author

yyzxw commented Aug 27, 2025

all commits are signed now.

@elevran
Copy link
Collaborator

elevran commented Aug 27, 2025

/lgtm
/approve

@github-actions github-actions bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2025
@github-actions github-actions bot merged commit 65ea8e0 into llm-d:main Aug 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider dropping plugin type qualifier from types and files

2 participants